fix: replace strpos with strrpos since file names could be kebap case #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerFloe
changed the title
|
Looks good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems to have been forgotten that vite uses base64 naming for the bundle prefix by default, which includes special characters such as
-: https://rollupjs.org/configuration-options/#output-hashcharactersThis could lead to issues and should be addressed in the plugin's documentation, since otherwise the function does not extract the hash as intended.
In addition to that
strposmight not be a proper function for determining the hash itself since the initial filename could be written in kebap case andstrposreturns the first occurrence of a given character. Therefore my suggestion would be to takestrrposinstead, as well as for determining the initialhashPos.All in all it might even be better to give the developer the opportunity to define a custom hash prefix by for example an environment variable, since vite also allows custom naming of the output files using rollup. https://rollupjs.org/configuration-options/
Kind regards
Related issues